-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom merge points #128
Allow custom merge points #128
Conversation
@IanButterworth This is great, thanks for suggesting this! |
Not sure why they're not showing up here still.. but the actions tests are passing on my branch https://github.com/IanButterworth/TimerOutputs.jl/runs/2906281500 This is the table for the additional test
|
I'm trying to add the accumulated data within a thread into the parents but it's not quite working. Perhaps this is ok, as "2" did only take 11ms (mostly compilation I assume) to return given it spawns, even though the child processes are ~300ms. So maybe it doesn't need fixing? This is after the latest commits
|
One way to handle multithreading seems to be to use local TimerOutput objects, but currently
merge!
just globally merges.This allows merging into a custom point in the destination
to
.otherwise, currently a
merge!(to, to2)
would result inI can add tests if this is welcomed