RFC: Allow prev_timer to be set to nothing #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change prev_timer type to Union{TimerOutput,Nothing}
Allow prev_time to be set to nothing to break circularity which can cause issues in some circumstances
For example when saving to JLD
|
Seems like a good idea. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circular self-reference of
prev_timerfield can cause problems in some circumstances.For example, exporting
TimerOutputusingJLDcausesStackOverflowError.Workaround for #40
I realise this is an issue for
JLDrather thanTimerOutputs, so marking as RFC. However, it seems to provide a workaround with little impact onTimerOutputs.Change type of
prev_timertoUnion{TimerOutput,Nothing}which allows setting it tonothing, breaking the circularity.It also seems consistent that
prev_timer == nothingwheneverprev_timer_label == "".Before saving to
JLD, setprev_timertonothing.