Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 232 version #3327

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

marceloneppel
Copy link
Contributor

@marceloneppel marceloneppel commented Aug 3, 2023

2023.2 (232 version) was released last week, and it doesn't support the current plugin version.

Fixes #3325.
Fixes #3326.

@StragaSevera
Copy link

@KronicDeth Is there any chance for this PR to be reviewed and merged? It sucks to have two separate IDE versions, because this plugin does not support the modern IDEA.

@sh41
Copy link
Contributor

sh41 commented Aug 10, 2023

Thanks as ever to @KronicDeth for this awesome plugin and thanks to @marceloneppel for the PR. I upgraded to 232 without checking versions and rather than downgrade I built the plugin from this PR so that I could test it out. If anyone else wants to use it, I've attached here. You can load it in the plugins manager by choosing ⚙️ and "Install plugin from disk". 👍
intellij-elixir-16.0.0-pre+20230810101552.zip

@StragaSevera
Copy link

@sh41
Thank you very much! I hope this plugin is not abandoned =-)

@gaggle
Copy link

gaggle commented Aug 18, 2023

Thanks as ever to @KronicDeth for this awesome plugin and thanks to @marceloneppel for the PR. I upgraded to 232 without checking versions and rather than downgrade I built the plugin from this PR so that I could test it out. If anyone else wants to use it, I've attached here. You can load it in the plugins manager by choosing ⚙️ and "Install plugin from disk". 👍
intellij-elixir-16.0.0-pre+20230810101552.zip

Thanks for taking the time to making this zip available, it looks to work great.

@Jestar342
Copy link

Thanks as ever to @KronicDeth for this awesome plugin and thanks to @marceloneppel for the PR. I upgraded to 232 without checking versions and rather than downgrade I built the plugin from this PR so that I could test it out. If anyone else wants to use it, I've attached here. You can load it in the plugins manager by choosing ⚙️ and "Install plugin from disk". 👍 intellij-elixir-16.0.0-pre+20230810101552.zip

Unfortunately, I was unable to successfully install this because it has a dependency on org.intellij.plugins.markdown which is also not compatible with 232.

@jameskbride
Copy link

@Jestar342 Can you elaborate on the markdown plugin not being compatible with 232? It clearly states it is as of July 18.

Screenshot 2023-09-02 at 4 07 54 PM

What version of Intellij are you running? Typically when a version bump of this plugin to accompany an Intellij version bump is released support for the old Intellij version is dropped, so if you're running an older version of Intellij and trying to install this zip it won't work.

@Jestar342
Copy link

image

@jameskbride

That's from the link I shared in my previous.

@sh41
Copy link
Contributor

sh41 commented Sep 4, 2023

@Jestar342. Gateway is beta software & not directly supported by this plugin. See https://github.com/KronicDeth/intellij-elixir#ides for the list of supported IDEs.

I'm using IDEA Ultimate and I don't see the incompatibility warning when I visit https://plugins.jetbrains.com/plugin/7793-markdown/versions/stable
image

In IDEA itself it's actually reporting a version number that isn't listed in the marketplace:
image

My current version string from Help>About:

IntelliJ IDEA 2023.2.1 (Ultimate Edition)
Build #IU-232.9559.62, built on August 23, 2023
Licensed to ***
Subscription is active until ***.
Runtime version: 17.0.8+7-b1000.8 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 5.15.90.1-microsoft-standard-wsl2
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Non-Bundled Plugins:
    net.sjrx.intellij.plugins.systemdunitfiles (223.230322.126)
    systems.fehn.intellijdirenv (0.2.9)
    awesome.console (0.1337.12)
    org.jetbrains.plugins.ruby (232.9559.62)
    YAML/Ansible support (0.11.2)
    org.elixir_lang (16.0.0-pre+20230810101552)
    org.jetbrains.erlang (0.11.1205)
    com.jetbrains.packagesearch.intellij-plugin (232.9559.10)

Kotlin: 232-1.9.0-IJ9559.62
Current Desktop: Undefined

@KronicDeth KronicDeth force-pushed the feat/support-intellij-232 branch from 3ff73f3 to 1c12275 Compare September 12, 2023 16:23
@KronicDeth KronicDeth enabled auto-merge (rebase) September 12, 2023 16:24
@KronicDeth KronicDeth merged commit e7d1547 into KronicDeth:main Sep 12, 2023
2 checks passed
@gaggle
Copy link

gaggle commented Sep 13, 2023

Thanks @KronicDeth !!! ❤️❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin incompatible with newest Intellij Idea 2023.2 Update to work with IntelliJ IDEA 2023.2
7 participants