Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Low: Previous & Confirm buttons in wrong places on sell character modal #64

Closed
3 tasks
Pandelissym opened this issue Oct 20, 2023 · 0 comments · Fixed by #66
Closed
3 tasks

Bug: Low: Previous & Confirm buttons in wrong places on sell character modal #64

Pandelissym opened this issue Oct 20, 2023 · 0 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@Pandelissym
Copy link
Contributor

Description:

In the sell character modal, after selecting a price for the character to sell and clicking next, the modal's Confirm and Previous buttons are placed incorrectly. See screenshot below:

Screenshot 2023-10-20 at 08 18 40

Repro

  • Go to the character tab
  • Make sure you own a character (if not mint one)
  • Click My Characters to open the characters overview
  • Select a character and click Sell
  • Enter a price and click Next
  • See that the Previous and Confirm buttons are in wrong places

Acceptance criteria

  • buttons are in correct places
  • QAed
  • merged with develop
@Pandelissym Pandelissym added the bug Something isn't working label Oct 20, 2023
@Pandelissym Pandelissym mentioned this issue Oct 20, 2023
Merged
Pandelissym added a commit that referenced this issue Oct 20, 2023
@Pandelissym
Fix button placement in sell modal and arrow svg (#66)
446c61d 
- Fixed the placement of confirm and previous buttons in sell modal (for
items and characters). Wrapped the buttons in wrapper and made the step
components a bit smaller so the buttons can fit nicely at the bottom.
- Removed padding from some arrow icons in the button so they show up
properly
 
closes #64

Co-authored-by: Pandelis Symeonidis <pandelis@kryha.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix button placement in sell modal and arrow svg Kryha/KREAd
1 participant
@Pandelissym