Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile onboarding/connect-wallet screens #107

Merged
merged 17 commits into from
Dec 13, 2023
Merged

Conversation

Pandelissym
Copy link
Contributor

@Pandelissym Pandelissym commented Dec 8, 2023

Description

Adjusted the onboarding screen to be mobile friendly.
Adjusted the connect-wallet page to be mobile friendly including error toasts and kado pop up.
Adjusted the privacy screen to be mobile friendly.

Closes #110

Screenshots (if applicable)

Screen.Recording.2023-12-12.at.11.35.01.mov

Checklist

Make sure all items are checked before submitting the pull request. Remove any items that are not applicable.

  • The PR title is clear and concise.
  • Are there changes in the /fronted folder? Make sure cd frontend && yarn build runs successfully.;

@Pandelissym Pandelissym changed the title Mobile/onboarding Mobile onboarding screen Dec 8, 2023
@Pandelissym Pandelissym changed the title Mobile onboarding screen Mobile onboarding/connect-wallet screens Dec 11, 2023
@Pandelissym Pandelissym marked this pull request as ready for review December 12, 2023 10:41
@carlos-kryha
Copy link
Contributor

the first paragraph in the "Who we are" section has some indentation issues
Screenshot 2023-12-12 at 12 51 09

@carlos-kryha
Copy link
Contributor

would be good to add some top margin/padding to the Who we are title

@Pandelissym
Copy link
Contributor Author

@carlos-kryha I fixed the identation issue by removing the newline characters from the text, now they can take the whole space freely. Didnt seem to affect the desktop version in a bad way.

Also added padding to the "Who we are section". Let me know if it needs some more adjusting.

@carlos-kryha
Copy link
Contributor

@carlos-kryha I fixed the identation issue by removing the newline characters from the text, now they can take the whole space freely. Didnt seem to affect the desktop version in a bad way.

Also added padding to the "Who we are section". Let me know if it needs some more adjusting.

oh right, I didn't realize we used newlines in the text consts that's kind of bad. Looking good now tho

@Pandelissym Pandelissym merged commit 09a7050 into develop Dec 13, 2023
3 checks passed
@Pandelissym Pandelissym deleted the mobile/onboarding branch December 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Onboarding Flow
2 participants