Support 'fullTemplateTypeCheck'

[Enngage]

Hi,

Currently compiling your library with fullTemplateTypeCheck angular option (introduced very recently) fails with just a few minor issues.

Could you take a look at those? Currently I can't use the option because of these errors.

[Ks89]

Ok. I'll check tomorrow.

Are you talking about version 5.0.0 beta?

[Enngage]

Yup. Cool :)

[Ks89]

I tried but I cannot reproduce this issue.
Are you really really sure that you are using 5.0.0-beta.1? If yes, can you try to use my official example with angular-cli here https://github.com/Ks89/angular-modal-gallery/tree/v4/examples/angular-cli?

[Enngage]

After enabling the template check, you need to build the library using --aot attribute for it to take effect. Instead of `ng build` use `ng build --aot` and you should see the errors in console.

…

On 1 February 2018 at 01:44, Stefano Cappa ***@***.***> wrote: I tried but I cannot reproduce this issue. Are you really really sure that you are using 5.0.0-beta.1? If yes, can you try to use my official example with angular-cli here https://github.com/Ks89/angular-modal-gallery/tree/v4/examples/angular-cli ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#122 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGzoR1Blwa3sZnnoOgl3YIZX9n4Lg1lUks5tQQjagaJpZM4Rzr1_> .

[Ks89]

@Enngage I cannot reproduce this issue (with --aot).

Please could you get this example https://github.com/Ks89/angular-modal-gallery/tree/v4/examples/angular-cli (install all deps with npm i) and try to build it by yourself? I really don't know what can I do to understand the problem. I suggest to try to compare it with your code.

PS: could you share your log with errors?

[Enngage]

I'm seeing following errors with the latest beta-2:

This seems to be coming from the library so I don't think my code is the problem. Maybe this is also related to 'strictNullChecks' ts config which I have enabled on my end as it is recommended.

[Ks89]

mmm, probably yes, it is 'strictNullChecks'. I'll check this weekend

[Ks89]

@Enngage you are right, this happens when you enable 'strictNullChecks'.

However the typescript's error is so ambiguous that It's difficult to understand the problem (this issue microsoft/TypeScript#8274 should be really closed :)). I need a couple of days to fix this. When I'm ready to close this issue, I'll release RC1.
Thank you for the hint of strictNullChecks.

PS: I'm adding to all tsconfig files of both the lib and the official examples this:

"angularCompilerOptions": {
    "fullTemplateTypeCheck": true,
    "preserveWhiteSpace": false,
    "strictInjectionParameters": true,
    "strictNullChecks": true
  },

Do you suggest to add other params to angularCompilerOptions?

[Ks89]

Fixed. Simpler than I expected.

I'll release RC1 this evening.

[Ks89]

RC1 released right now 👍

[Enngage]

Thanks :) I can confirm it works fine now. As for the CompilerOptions - that seems to be for now.