Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when only one photo, the photo is not centered #136

Closed
pieterdegraeuwe opened this issue Apr 12, 2018 · 6 comments
Closed

when only one photo, the photo is not centered #136

pieterdegraeuwe opened this issue Apr 12, 2018 · 6 comments

Comments

@pieterdegraeuwe
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report 
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

When there is only one photo, the photo is not centered, but left aligned.

Expected behavior

Photo should be centered

Minimal reproduction of the problem with instructions

See punker (and click on the firest (and only) photo )
https://plnkr.co/edit/yBu18OCZQQjHPdyR0UGY?p=preview

What is the motivation / use case for changing the behavior?

Environment (the most important section to fill very carefully)


- Node version: 6.11.0
- npm version: 3.10.10
- Operating System and version:  Windows 
- Angular version: X.Y.Z 
- angular-cli version (or SystemJS/Webpack): X.Y.Z 
- I'm using Server Side Rendering with angular-universal: YES/NO
- I'm compiling with mode: DEBUG / PROD / PROD with AOT



Browser:
- [x] Chrome (desktop) version 65.0.3325.181
- [x] Firefox version 59.02
- [x] Edge version 41.16299.248.0
- [x] Opera version 52.0.2871.40



@Ks89
Copy link
Owner

Ks89 commented Apr 16, 2018

Damn, you are right. It's happing on mobile phones.
I'll try to fix it this week.

@Ks89
Copy link
Owner

Ks89 commented Apr 17, 2018

Probably, I won't fix it this week, because I'm really busy, but I'll try asap. Please be patient.

@Ks89
Copy link
Owner

Ks89 commented Apr 25, 2018

Sorry for the delay, but I was really busy.
I'll try to fix it this weekend or before the end of next week.

Ks89 added a commit that referenced this issue Apr 27, 2018
@Ks89
Copy link
Owner

Ks89 commented Apr 27, 2018

Thank you for your patience.
Issue fixed in 5.5.1.

Feel free to re-open if you think that it's not ok.

@Ks89 Ks89 closed this as completed Apr 27, 2018
@pieterdegraeuwe
Copy link
Author

however this issue is already closed (my fault, sorry for that), I confirm that this issue is indeed fixed !
Thanks for the excellent work !

@Ks89
Copy link
Owner

Ks89 commented May 2, 2018

@pieterdegraeuwe
thank u and I'm happy that you are happy :).

Feel free to both express your ideas and to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants