Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlideConfig Bug #156

Closed
rezo-evodion opened this issue Aug 17, 2018 · 3 comments
Closed

SlideConfig Bug #156

rezo-evodion opened this issue Aug 17, 2018 · 3 comments

Comments

@rezo-evodion
Copy link

I'm submitting a...


[*] Bug report  
[* ] Feature request

I do not know if it is a Bug or Feature Request but I am sure you can find it out,

Current behavior

Use [slideConfig]="{infinite: true, sidePreviews: {show: false}}, I can see the next and Previous Image Buttons when there is only one Image in Gallery.

Expected behavior

Next and Previous Button in case one Image in Gallery are hidden,

What is the motivation / use case for changing the behavior?

Hide the Button when they don't have any functionality.

Environment (the most important section to fill very carefully)


- Node version: v8.11.3  
- npm version: 5.6.0  
- Operating System and version:  < Windows 10>
- Angular version: 6.1 
- angular-cli version (or SystemJS/Webpack):  6.0.8 
- I'm using Server Side Rendering with angular-universal: YES
- I'm compiling with mode: DEBUG 



Browser:
- [*] Chrome (desktop) version 68.0.3440.106
- [* ] Firefox version 61.0.2


@Ks89
Copy link
Owner

Ks89 commented Aug 17, 2018

you are right. This issue is caused by 'infinite: true' with only one image. I'll fix it.

Do you need a quick fix? Or can I add it directly to version 7.0.0?

@rezo-evodion
Copy link
Author

when you can provide a quick fix, it will be great because it should be done next monday.
Thanks for quick response.

Ks89 added a commit that referenced this issue Aug 17, 2018
@Ks89
Copy link
Owner

Ks89 commented Aug 17, 2018

6.2.1 released with a fix. Feel free to re-open if you find this issue again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants