Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIsplay previews on small screens #213

Closed
vlafranca opened this issue Oct 12, 2020 · 5 comments
Closed

DIsplay previews on small screens #213

vlafranca opened this issue Oct 12, 2020 · 5 comments

Comments

@vlafranca
Copy link

vlafranca commented Oct 12, 2020

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[x] Support request

Current behavior

Hi,
I noticed that the previews are hidden by default on small screens (>768px) via css rules inspectables in the browser. Is it possible to keep previews on screens below 768px ?
Best solution would be to be able to customize this :

@media only screen and (max-width: 767px), only screen and (max-device-width: 767px) {
.previews-container {
 display: none;  
 > .preview-image {
 display: none;
 }

Thanks in advance

Expected behavior

Previews should be displayed on small screens

Minimal reproduction of the problem with instructions

Open any modal example on the live demo, then shrink your browser width, the previews will disapear.

What is the motivation / use case for changing the behavior?

Would be nice to have to customize whether or not we want to display the previews on small screens

Environment (the most important section to fill very carefully)


- @ks89/angular-modal-gallery version: latest
- Node version: 12  
- npm version: 12  
- Operating System and version:  Windows
- Angular version: 9
- angular-cli version (or SystemJS/Webpack): X.Y.Z 
- I'm using Server Side Rendering with angular-universal: NO
- I'm compiling with mode: DEBUG



Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
@Ks89
Copy link
Owner

Ks89 commented Oct 15, 2020

Hi, I'm sorry for the delay.
At the moment this is not possible.

@vlafranca
Copy link
Author

vlafranca commented Oct 15, 2020 via email

@Ks89
Copy link
Owner

Ks89 commented Oct 16, 2020

Because, I didn't implement it.

If you want yes, however, please use branch develop to add this feature to the next major release 8.0.0.

@vlafranca
Copy link
Author

Great I will submit something soon

@Ks89
Copy link
Owner

Ks89 commented Nov 22, 2020

pull request merged

@Ks89 Ks89 closed this as completed Nov 22, 2020
@Ks89 Ks89 added this to the 8.0.0 milestone Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants