Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth policy metrics #38

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

Ygnas
Copy link
Collaborator

@Ygnas Ygnas commented Oct 25, 2023

Closes: #4

@Ygnas Ygnas marked this pull request as ready for review October 25, 2023 15:55
@david-martin
Copy link
Collaborator

Thanks @Ygnas
This is working & looking as expected.
image

What are you thoughts on having a link from the target name to the target page, filtered to that specific target?
For example, if I click on accounts in the above screenshot, the HTTPRoutes page is opened, filtered to the accounts HTTPRoute?
This would be the same behaviour as when clicking on the accounts HTTPRoute on the Gateway page below
image

@Ygnas
Copy link
Collaborator Author

Ygnas commented Oct 26, 2023

Thanks @Ygnas This is working & looking as expected. image

What are you thoughts on having a link from the target name to the target page, filtered to that specific target? For example, if I click on accounts in the above screenshot, the HTTPRoutes page is opened, filtered to the accounts HTTPRoute? This would be the same behaviour as when clicking on the accounts HTTPRoute on the Gateway page below image

Agreed, this can improve the navigation and make it more intuitive. I will make the changes to have it consistent with the behaviour you mentioned when clicking on the accounts HTTPRoute on the Gateway page.

@Ygnas Ygnas force-pushed the auth-policy-metrics branch 3 times, most recently from 2fb949a to e15d416 Compare October 26, 2023 12:44
Copy link
Collaborator

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Ygnas for adding the AuthPolicy examples.
Looks good
image

@david-martin david-martin merged commit 8a1c230 into Kuadrant:main Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: Policy Attachment metrics (investigate/proof of concept)
3 participants