Set gateway-api-state-metrics version to 0.4.0 (latest at this time) … #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to pickup new field
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 80.20% 82.70% +2.49%
==========================================
Files 64 73 +9
Lines 4492 5737 +1245
==========================================
+ Hits 3603 4745 +1142
- Misses 600 656 +56
- Partials 289 336 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlaw4608
pushed a commit
to dlaw4608/kuadrant-operator
that referenced
this pull request
Jun 17, 2024
Kuadrant#695) * Set gateway-api-state-metrics version to 0.4.0 (latest at this time) to pickup new field * Add gateway listeners panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to pickup new field introduced in Kuadrant/gateway-api-state-metrics#43
Fixes #667
To show this new field, I think it makes sense to have a new panel to show Gateway Listeners, including all the fields of a listener that are available via state metrics.
Here's where the new panel fits in, with a slight change to the layout of the PE dashbaord. (lot of fields, so needs scrolling)
And here's the panel showing all the fields when stretched out to accomodate them without scrolling (including the new 'allowed_routes_namespaces_from' field)
