Refactoring service name and metrics port to match authorino #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Lawton
commented
Jul 4, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 85.31% 84.40% -0.91%
==========================================
Files 19 19
Lines 994 994
==========================================
- Hits 848 839 -9
- Misses 95 100 +5
- Partials 51 55 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eguzki
requested changes
Jul 4, 2024
| @@ -0,0 +1,17 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
In the bundle dir, there are now two metric services, right? one should be removed.
There was a problem hiding this comment.
Oops yes good catch
…cs port to make limitador operator more inline with authorino-operator
eguzki
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating metrics service name and removing patch for metrics port to make limitador operator more inline with authorino-operator. The conversation that sparked changes: Kuadrant/authorino-operator#187
Verification:
make local-setupVerify metrics port 8080 is being shown
kubectl get deployment limitador-operator-controller-manager -n limitador-operator-system -o yamlEnsure the metrics service looks like below
kubectl get service -A