Skip to content

Commit

Permalink
[plugin] fix support on expo sdk 49 (rn 0.72) #2 (#188)
Browse files Browse the repository at this point in the history
# Why

follow up #187

# How

add the missing the hermes-android

# Test Plan

try the reproducible example from expo/expo#23312
  • Loading branch information
Kudo authored Jul 6, 2023
1 parent 7426023 commit e974310
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions plugin/build/withV8ExpoAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ android {
}
}
}
dependencies {
debugImplementation('com.facebook.react:hermes-android')
}
`;
let mergeResults;
mergeResults = (0, generateCode_1.mergeContents)({
Expand Down
4 changes: 4 additions & 0 deletions plugin/src/withV8ExpoAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ android {
}
}
}
dependencies {
debugImplementation('com.facebook.react:hermes-android')
}
`;

let mergeResults: MergeResults;
Expand Down

0 comments on commit e974310

Please sign in to comment.