Fix cmake error on windows #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
piaskowyk
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Nov 10, 2022
## Description I get cmake error (`Invalid character escape '\K'.`) when using latest Reanimated on RN version 0.64.3, this will fix Android build on windows because latest version of reanimated doesn't provide prebuilt AAR for older version, so it will attempt to rebuild from source  ## Changes - added method `toPlatformFileString(File path)` to android/build.gradle to replace windows file separator character with '/' - call `toPlatformFileString` on cmake arguments REACT_NATIVE_DIR - fix sources taken from [this PR](Kudo/react-native-v8#132) ## Test code and steps to reproduce - create new project with RN v0.64.3 - install latest version of react-native-reanimated - try to build apk for Android `./gradlew clean installDebug` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
piaskowyk
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Nov 10, 2022
## Description I get cmake error (`Invalid character escape '\K'.`) when using latest Reanimated on RN version 0.64.3, this will fix Android build on windows because latest version of reanimated doesn't provide prebuilt AAR for older version, so it will attempt to rebuild from source  ## Changes - added method `toPlatformFileString(File path)` to android/build.gradle to replace windows file separator character with '/' - call `toPlatformFileString` on cmake arguments REACT_NATIVE_DIR - fix sources taken from [this PR](Kudo/react-native-v8#132) ## Test code and steps to reproduce - create new project with RN v0.64.3 - install latest version of react-native-reanimated - try to build apk for Android `./gradlew clean installDebug` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description I get cmake error (`Invalid character escape '\K'.`) when using latest Reanimated on RN version 0.64.3, this will fix Android build on windows because latest version of reanimated doesn't provide prebuilt AAR for older version, so it will attempt to rebuild from source  ## Changes - added method `toPlatformFileString(File path)` to android/build.gradle to replace windows file separator character with '/' - call `toPlatformFileString` on cmake arguments REACT_NATIVE_DIR - fix sources taken from [this PR](Kudo/react-native-v8#132) ## Test code and steps to reproduce - create new project with RN v0.64.3 - install latest version of react-native-reanimated - try to build apk for Android `./gradlew clean installDebug` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jan 9, 2024
# Why fixes #26206 close ENG-10993 # How cmake path separator should be `/` always. refer to Kudo/react-native-v8#132 fix but refine the method name a little bit # Test Plan - ci passed - test building on windows
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jan 10, 2024
# Why fixes #26206 close ENG-10993 # How cmake path separator should be `/` always. refer to Kudo/react-native-v8#132 fix but refine the method name a little bit # Test Plan - ci passed - test building on windows (cherry picked from commit 175fcd7)
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why fixes expo#26206 close ENG-10993 # How cmake path separator should be `/` always. refer to Kudo/react-native-v8#132 fix but refine the method name a little bit # Test Plan - ci passed - test building on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix #115
How
the path on windows is not correct:
C:\DEV\...\node_modules\react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp.replace file separators to
/also on windows