Support expo-dev-client #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Sep 16, 2022
# Why another attempt than #18151 to support react-native-v8 # How if there's *libv8android.so*, we just use the js executor factory from main ReactNativeHost. for the bundled reanimated in dev-menu, i have a pr to keep jsc in debug build: Kudo/react-native-v8#142 # Test Plan ```sh $ yarn create expo-app -t blank@sdk-46 sdk46v8 $ cd sdk46v8 $ npx expo install react-native-v8 v8-android-jit # add "plugins": ["react-native-v8"] to app.json $ npx expo install expo-dev-client $ npx expo prebuild -p android # patch node_modules/expo-dev-launcher $ npx expo run:android ```
lukmccall
pushed a commit
to expo/expo
that referenced
this pull request
Sep 16, 2022
# Why another attempt than #18151 to support react-native-v8 # How if there's *libv8android.so*, we just use the js executor factory from main ReactNativeHost. for the bundled reanimated in dev-menu, i have a pr to keep jsc in debug build: Kudo/react-native-v8#142 # Test Plan ```sh $ yarn create expo-app -t blank@sdk-46 sdk46v8 $ cd sdk46v8 $ npx expo install react-native-v8 v8-android-jit # add "plugins": ["react-native-v8"] to app.json $ npx expo install expo-dev-client $ npx expo prebuild -p android # patch node_modules/expo-dev-launcher $ npx expo run:android ```
Ddv0623
pushed a commit
to omniaintranet/expo
that referenced
this pull request
Sep 26, 2022
# Why another attempt than expo#18151 to support react-native-v8 # How if there's *libv8android.so*, we just use the js executor factory from main ReactNativeHost. for the bundled reanimated in dev-menu, i have a pr to keep jsc in debug build: Kudo/react-native-v8#142 # Test Plan ```sh $ yarn create expo-app -t blank@sdk-46 sdk46v8 $ cd sdk46v8 $ npx expo install react-native-v8 v8-android-jit # add "plugins": ["react-native-v8"] to app.json $ npx expo install expo-dev-client $ npx expo prebuild -p android # patch node_modules/expo-dev-launcher $ npx expo run:android ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo-dev-client has bundled reanimated that doesn't support v8. this pr is addressing the issue.
How
this is a just work and not perfect solution. since expo-dev-client is only for debug build, we could leave jsc libraries only in debug build. originally our config-plugin tries to remove libjsc* for all build variants. now the config-plugin only removes jsc in release build. it will append the following statements into android/app/build.gradle