Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt and V8Inspector for React Native 0.73 compatibility #195

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Update CMakeLists.txt and V8Inspector for React Native 0.73 compatibility #195

merged 6 commits into from
Jan 22, 2024

Conversation

Serck96
Copy link
Contributor

@Serck96 Serck96 commented Jan 13, 2024

No description provided.

Kudo
Kudo reviewed Jan 14, 2024
View reviewed changes
Copy link
Owner

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great pr! thanks for updating this. leaving some comments and after that it should be good to merge

android/CMakeLists.txt Outdated Show resolved Hide resolved
src/v8runtime/V8Inspector.cpp Outdated Show resolved Hide resolved
src/v8runtime/V8Inspector.h Outdated Show resolved Hide resolved
Serck96 and others added 3 commits January 14, 2024 18:20
@Serck96 @Kudo
Update android/CMakeLists.txt
8616745 
Co-authored-by: Kudo Chien <ckchien@gmail.com>
@Serck96 @Kudo
Update src/v8runtime/V8Inspector.cpp
c13e8dc 
Co-authored-by: Kudo Chien <ckchien@gmail.com>
@Serck96
Update V8Inspector namespace
bacfae1
@verluci
Copy link

verluci commented Jan 19, 2024

Could you update the documentation to reflect the changes needed in MainApplication.kt (previously MainApplication.java)?

@Serck96
Copy link
Contributor Author

Serck96 commented Jan 19, 2024

Hi @verluci ,

I just wanted to let you know that I've updated the documentation with the changes you requested for MainApplication.kt. The updated configuration and instructions are now available in the repository's documentation.

Feel free to check it out and let me know if it works for you or if there are any further adjustments needed.

Kudo
Kudo reviewed Jan 21, 2024
View reviewed changes
Copy link
Owner

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking to pass ci, but given the ci is broken and don't have bandwidth to fix that. i would rather to build locally and it works fine.
there's just one remaining one recommended change, otherwise it's good to merge. thanks for helping the pr.

src/v8runtime/V8Inspector.h Outdated Show resolved Hide resolved
Kudo
Kudo approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for the awesome work 🔥 let's ship it 🚀

@Kudo Kudo merged commit c9f878c into Kudo:main Jan 22, 2024
0 of 10 checks passed
@Kudo
Copy link
Owner

Kudo commented Jan 22, 2024

react-native-v8@2.3.0 published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Kudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serck96 @verluci @Kudo