V8PointerValue should not be GCed automatically. Fixes #2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
JSI uses PointerValue to allocate String, Object, ...etc,
and JSI controls life cycle itself from invalidate().
JSCRuntime did use JSValueUnprotect() to prevent these values being GCed.
For V8Runtime, we just need to keep they wrapped as v8::Glocal<> and not as weak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSI uses PointerValue to allocate String, Object, ...etc,
and JSI controls life cycle itself from invalidate().
JSCRuntime did use JSValueUnprotect() to prevent these values being GCed.
For V8Runtime, we just need to keep they wrapped as v8::Glocal<> and not as weak.
For #2, the
NativeModules.DialogManagerAndroidwill first initialize correctly.However, during the callback from Alert button clicked, If GC happened, some properties in
NativeModules.DialogManagerAndroidmay not exist and lead to exception.