Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeneratorBundle] Add webpack encore - keep Groundcontrol as option #2981

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

dbeerten
Copy link
Contributor

@dbeerten dbeerten commented Oct 12, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

TODO:

  • Check admin JS & CSS
  • Check if Webpack encore setup works (with and without demosite flag)
  • Check if Groundcontrol setup still works (with and without demosite flag)
  • doc install composer require symfony/webpack-encore-bundle
    added symfony/webpack-encore-bundle to cms-skeleton: Add webpack-encore-bundle cms-skeleton#9
  • update stylelint & eslint to latest versions (incl configs)
  • adjust cookie bundle

BLOCKED BY:

Feedback?

  • Deleted the styleguide for now, should we keep it?
    We can't use Webpack Encore to build the assets as it is not rendered by Symfony
  • By default, the cms-skeleton installs the symfony/webpack-encore-bundle package. When Groundcontrol is prefered, this package needs to be removed. Where should we document this? (also: by removing this package, the package.json gets deleted)

@acrobat
Copy link
Member

acrobat commented Oct 22, 2021

Blocked by: symfony/webpack-encore-bundle#147 for optionally allowing to override admin js/css

@acrobat
Copy link
Member

acrobat commented Oct 22, 2021

It's maybe a good idea to switch from public/frontend to public/build as the base output dir when using webpack encore? As the webpack encore bundle recipes default adds the build dir to gitignore

https://github.com/symfony/recipes/blob/22ddf06812d17b39ba291eb6aab8ec2bfd0abd3a/symfony/webpack-encore-bundle/1.9/manifest.json#L14

@dbeerten dbeerten force-pushed the webpack-encore branch 2 times, most recently from 983b992 to 6cc8297 Compare December 2, 2021 16:37
@dbeerten dbeerten force-pushed the webpack-encore branch 2 times, most recently from dd2fefa to b03a761 Compare February 10, 2022 07:39
@dbeerten dbeerten changed the base branch from master to 6.x February 10, 2022 07:39
@dbeerten dbeerten force-pushed the webpack-encore branch 2 times, most recently from c23fbc5 to 7cbea78 Compare February 14, 2022 12:28
@dbeerten dbeerten changed the title [WIP][GeneratorBundle] Add webpack encore option - keep Groundcontrol as default [WIP][GeneratorBundle] Add webpack encore - keep Groundcontrol as option Feb 14, 2022
@dbeerten dbeerten force-pushed the webpack-encore branch 3 times, most recently from 7247c37 to 5279516 Compare February 14, 2022 12:52
@dbeerten dbeerten force-pushed the webpack-encore branch 4 times, most recently from ad0dd8e to 3192452 Compare February 17, 2022 15:47
@dbeerten dbeerten changed the title [WIP][GeneratorBundle] Add webpack encore - keep Groundcontrol as option [GeneratorBundle] Add webpack encore - keep Groundcontrol as option Feb 18, 2022
@acrobat acrobat added this to the 6.2.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants