-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeneratorBundle] Add webpack encore - keep Groundcontrol as option #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeerten
force-pushed
the
webpack-encore
branch
from
October 12, 2021 14:53
da92779
to
f7690fe
Compare
dbeerten
force-pushed
the
webpack-encore
branch
from
October 12, 2021 15:00
f7690fe
to
e3347b7
Compare
acrobat
reviewed
Oct 22, 2021
src/Kunstmaan/GeneratorBundle/Command/GenerateDefaultSiteCommand.php
Outdated
Show resolved
Hide resolved
.../GeneratorBundle/Resources/SensioGeneratorBundle/skeleton/layout/webpack-encore/package.json
Outdated
Show resolved
Hide resolved
...ratorBundle/Resources/SensioGeneratorBundle/skeleton/layout/webpack-encore/webpack.config.js
Outdated
Show resolved
Hide resolved
Blocked by: symfony/webpack-encore-bundle#147 for optionally allowing to override admin js/css |
It's maybe a good idea to switch from public/frontend to public/build as the base output dir when using webpack encore? As the webpack encore bundle recipes default adds the build dir to gitignore |
dbeerten
force-pushed
the
webpack-encore
branch
2 times, most recently
from
December 2, 2021 16:37
983b992
to
6cc8297
Compare
dbeerten
force-pushed
the
webpack-encore
branch
2 times, most recently
from
February 10, 2022 07:39
dd2fefa
to
b03a761
Compare
dbeerten
force-pushed
the
webpack-encore
branch
from
February 10, 2022 07:59
b03a761
to
d6d7b99
Compare
acrobat
requested changes
Feb 10, 2022
...ratorBundle/Resources/SensioGeneratorBundle/skeleton/layout/webpack-encore/webpack.config.js
Outdated
Show resolved
Hide resolved
src/Kunstmaan/NodeBundle/Resources/views/NodeAdmin/edit.html.twig
Outdated
Show resolved
Hide resolved
dbeerten
force-pushed
the
webpack-encore
branch
2 times, most recently
from
February 14, 2022 12:28
c23fbc5
to
7cbea78
Compare
dbeerten
changed the title
[WIP][GeneratorBundle] Add webpack encore option - keep Groundcontrol as default
[WIP][GeneratorBundle] Add webpack encore - keep Groundcontrol as option
Feb 14, 2022
dbeerten
force-pushed
the
webpack-encore
branch
3 times, most recently
from
February 14, 2022 12:52
7247c37
to
5279516
Compare
dbeerten
force-pushed
the
webpack-encore
branch
4 times, most recently
from
February 17, 2022 15:47
ad0dd8e
to
3192452
Compare
dbeerten
force-pushed
the
webpack-encore
branch
from
February 18, 2022 14:01
3192452
to
3948cea
Compare
dbeerten
changed the title
[WIP][GeneratorBundle] Add webpack encore - keep Groundcontrol as option
[GeneratorBundle] Add webpack encore - keep Groundcontrol as option
Feb 18, 2022
dbeerten
force-pushed
the
webpack-encore
branch
from
February 21, 2022 08:51
3948cea
to
94e2e05
Compare
acrobat
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
doc install composer require symfony/webpack-encore-bundleadded symfony/webpack-encore-bundle to cms-skeleton: Add webpack-encore-bundle cms-skeleton#9
BLOCKED BY:
Add encore_entry_exists() twig functions to check if entrypoint has files symfony/webpack-encore-bundle#147with Groundcontrol setup, theencore_entry_exists
twig function is not available and results in a render error: [AdminBundle] Handle possible missing encore_entry_exists twig function in legacy groundcontrol FE setup #3074Feedback?
We can't use Webpack Encore to build the assets as it is not rendered by Symfony