Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Added error handler #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added error handler #27

wants to merge 2 commits into from

Conversation

chop0
Copy link
Contributor

@chop0 chop0 commented Nov 23, 2020

Before issuing a pull request, please see the contributing page.

@chop0 chop0 added the draft label Nov 23, 2020
@chop0 chop0 changed the title Added error handler -- UNTESTED Added error handler Nov 27, 2020
@chop0 chop0 requested a review from e3l November 27, 2020 18:39
@chop0 chop0 removed the draft label Nov 27, 2020
Copy link
Contributor

@e3l e3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, small changes (http bad) and also want to see how this acts on the actual robot.

@@ -52,8 +53,12 @@ public Robot(HardwareMap hardwareMap, Telemetry telemetry, LinearOpMode linearOp
this.telemetryDump = new TelemetryDump(telemetry);
fileDump = new FileDump();

Thread.UncaughtExceptionHandler exceptionHandler = new KuriousErrorHandler(linearOpMode);
https://docs.oracle.com/javase/1.5.0/docs/api/java/lang/Thread.html#setDefaultUncaughtExceptionHandler(java.lang.Thread.UncaughtExceptionHandler)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad please fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it compiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very powerful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quirk

@@ -52,8 +53,12 @@ public Robot(HardwareMap hardwareMap, Telemetry telemetry, LinearOpMode linearOp
this.telemetryDump = new TelemetryDump(telemetry);
fileDump = new FileDump();

Thread.UncaughtExceptionHandler exceptionHandler = new KuriousErrorHandler(linearOpMode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add all exception handlers in a separate function for cleanliness :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants