-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add support to manage token based auth #527
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
4f6d066
to
ec47187
Compare
Thanks for your contribution! |
@peter-wangxu Welcome! 👋 You are right, we are currently preparing to optimize certificate verification (such as #521 ) because it is not yet universal, so thank you for your PR, it's very useful! |
If uploading a token based kubeconfig, error reported as invalid kubeconfig. In fact, token based kubeconfig is general usage in many cases. ref: https://kb.leaseweb.com/products/kubernetes/users-roles-and-permissions-on-kubernetes-rbac/create-a-token-based-kubeconfig
ec47187
to
46b3bc9
Compare
tests should be paased now. |
@peter-wangxu Thank you! If there is no problem after actual verification, we will merge it. Then we will release a small version, you can install to try it out. |
Great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@peter-wangxu Hi~ This PR has been merged and released with a new version v0.4.1. You can install it by specifying the chart version: helm repo update
helm install karpor kusionstack/karpor --version 0.4.1 |
What type of PR is this?
/kind refactor
What this PR does / why we need it:
If uploading a token based kubeconfig, error reported as invalid kubeconfig.
In fact, token based kubeconfig is general usage in many cases.
ref: https://kb.leaseweb.com/products/kubernetes/users-roles-and-permissions-on-kubernetes-rbac/create-a-token-based-kubeconfig