Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore the k8s automatic injection fields such as managedFields #582

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

regend
Copy link
Contributor

@regend regend commented Aug 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

把yaml中的managedFields字段设置为空,优化体验

Which issue(s) this PR fixes:

Fixes #461

Copy link

github-actions bot commented Aug 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@regend
Copy link
Contributor Author

regend commented Aug 12, 2024

I have read the CLA Document and I hereby sign the CLA

@regend
Copy link
Contributor Author

regend commented Aug 12, 2024

@cla-bot check

pkg/version/VERSION Outdated Show resolved Hide resolved
@elliotxx
Copy link
Collaborator

@regend Welcome to contribute! 🎉 I have left a few comments, you can take a look again.

@elliotxx
Copy link
Collaborator

elliotxx commented Aug 12, 2024

@regend Strange. CLA CI seems to have some problems, could you please reply to this paragraph again.
"I have read the CLA Document and I hereby sign the CLA"

@regend
Copy link
Contributor Author

regend commented Aug 12, 2024

I have read the CLA Document and I hereby sign the CLA

@elliotxx elliotxx changed the title feat: yaml中的managedFields字段设置为空,优化体验 feat: ignore the k8s automatic injection fields such as managedFields Aug 13, 2024
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 874f859 into KusionStack:main Aug 13, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@elliotxx
Copy link
Collaborator

@regend Welcome to become the Karpor contributor, looking forward to your more participation! 🎉 #585

@elliotxx elliotxx added this to the v0.5.0 milestone Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experience: k8s automatic injection fields such as managedFields need to be ignored on YAML page
3 participants