Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(syncer): log transform func error #587

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

iamryanchia
Copy link
Contributor

What type of PR is this?

/kind style

What this PR does / why we need it:

The transform func is called internally by the informer, the error will be hidden if we don't log them.

Which issue(s) this PR fixes:

Fixes #

Copy link
Collaborator

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruquanzhao ruquanzhao merged commit 2b90ce3 into KusionStack:main Aug 13, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants