Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a flag --enable-rbac to control authorization #631

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

ruquanzhao
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

This pr set RBAC authorization off on default.

Which issue(s) this PR fixes:

Fixes #

@ruquanzhao
Copy link
Collaborator Author

ruquanzhao commented Nov 11, 2024

It need some front-end code to fix this issue. Let's proceed after the front-end code is ready.

This PR is ready to be reviewed. cc @elliotxx

@ruquanzhao ruquanzhao changed the title (WIP)fix: set EnableRBAC false on default fix: set EnableRBAC false on default Nov 22, 2024
@ruquanzhao ruquanzhao changed the title fix: set EnableRBAC false on default feat: add a flag --enable-rbac to control authorization Nov 22, 2024
@ruquanzhao
Copy link
Collaborator Author

BREAKING CHANGE:if you are using karpor version between v0.4.9 and v0.5.4, please add --enable-rbac=true to karpor server args to keep safety.

BREAKING CHANGE:if you are using karpor version between v0.4.9 and v0.5.4, please add --enable-rbac=true to karpor server args to keep safety.
Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 9bd0205 into main Nov 22, 2024
8 of 9 checks passed
@elliotxx elliotxx deleted the fixRbac branch November 22, 2024 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants