Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inplaceOnlyPodUpdater plugin #250

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Refactor inplaceOnlyPodUpdater plugin #250

merged 6 commits into from
Aug 19, 2024

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.31%. Comparing base (d3f1f41) to head (51ac8d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   66.18%   66.31%   +0.12%     
==========================================
  Files          78       78              
  Lines        5536     5536              
==========================================
+ Hits         3664     3671       +7     
+ Misses       1518     1513       -5     
+ Partials      354      352       -2     
Flag Coverage Δ
unittests 66.31% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail changed the title Inplace only plugin Refactor inplaceOnlyPodUpdater plugin Aug 15, 2024
@ColdsteelRail ColdsteelRail force-pushed the inplaceOnly-plugin branch 3 times, most recently from 5873406 to dbdc8dd Compare August 19, 2024 04:44
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 9ee5e51 into main Aug 19, 2024
10 checks passed
@wu8685 wu8685 deleted the inplaceOnly-plugin branch August 19, 2024 05:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants