Skip to content

Commit

Permalink
feat: do not return err when open url failed
Browse files Browse the repository at this point in the history
  • Loading branch information
liu-hm19 committed Apr 22, 2024
1 parent ddb8c07 commit 55a896b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/engine/operation/browse_port.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (bpo *BrowsePortOperation) BrowsePort(req *BrowsePortRequest) error {
urlStr := fmt.Sprintf("http://localhost:%d", localPort)

if err := browser.OpenURL(urlStr); err != nil {
return fmt.Errorf("failed to open url '%s' with local browser: %v", urlStr, err)
fmt.Printf("\nOpen URL '%s' with local browser failed: %v\n", urlStr, err)
}

err := <-failed
Expand Down

0 comments on commit 55a896b

Please sign in to comment.