Skip to content

Commit

Permalink
fix: some uts
Browse files Browse the repository at this point in the history
1. delete duplicate app config generator tests
2. fix util_test.go
3. comment module related e2e tests
  • Loading branch information
SparkYuan committed Mar 13, 2024
1 parent 307d4e5 commit a765748
Showing 1 changed file with 23 additions and 22 deletions.
45 changes: 23 additions & 22 deletions test/e2e/e2e_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,28 +84,29 @@ func createSampleWorkspace() error {
}
ws := &v1.Workspace{
Name: "dev",
Modules: v1.ModuleConfigs{
"database": {
Default: v1.GenericConfig{
"type": "aws",
"version": "5.7",
"instanceType": "db.t3.micro",
},
ModulePatcherConfigs: v1.ModulePatcherConfigs{
"smallClass": {
GenericConfig: v1.GenericConfig{
"instanceType": "db.t3.small",
},
ProjectSelector: []string{"foo", "bar"},
},
},
},
"port": {
Default: v1.GenericConfig{
"type": "aws",
},
},
},
// comment out for now, as download modules from remote repo is not supported yet.
//Modules: v1.ModuleConfigs{
// "database": {
// Default: v1.GenericConfig{
// "type": "aws",
// "version": "5.7",
// "instanceType": "db.t3.micro",
// },
// ModulePatcherConfigs: v1.ModulePatcherConfigs{
// "smallClass": {
// GenericConfig: v1.GenericConfig{
// "instanceType": "db.t3.small",
// },
// ProjectSelector: []string{"foo", "bar"},
// },
// },
// },
// "port": {
// Default: v1.GenericConfig{
// "type": "aws",
// },
// },
//},

Check failure on line 109 in test/e2e/e2e_suite_test.go

View workflow job for this annotation

GitHub Actions / Golang Lint

commentFormatting: put a space between `//` and comment text (gocritic)
}
return wsOperator.CreateWorkspace(ws)
}
Expand Down

0 comments on commit a765748

Please sign in to comment.