Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Preview detail failed on Windows #534

Closed
SparkYuan opened this issue Sep 12, 2023 · 1 comment · Fixed by #819
Closed

Bug: Preview detail failed on Windows #534

SparkYuan opened this issue Sep 12, 2023 · 1 comment · Fixed by #819
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@SparkYuan
Copy link
Member

SparkYuan commented Sep 12, 2023

What happened?

Preview detail failed on Windows when applying the single-stack demo

20230912160713

What did you expect to happen?

show diff details

How can we reproduce it (as minimally and precisely as possible)?

  1. kusion init and choose the single-stack template
  2. kusion apply and choose one resource with a update action

Anything else we need to know?

No response

Kusion version

$ kusion version
# paste output here

v0.8.2

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

windows 12

Install tools

@SparkYuan SparkYuan added the kind/bug Something isn't working label Sep 12, 2023
@SparkYuan SparkYuan self-assigned this Sep 12, 2023
@adohe adohe assigned healthjyk and unassigned SparkYuan Sep 18, 2023
@ffforest ffforest added this to the 0.9.0 milestone Sep 18, 2023
@ffforest ffforest modified the milestones: 0.9.0, 0.10.0 Oct 7, 2023
@adohe adohe modified the milestones: 0.10.0, v0.11.0 Jan 19, 2024
@healthjyk
Copy link
Contributor

This is the bug of IsGardenContainer which is called by GetTerminalSize of package github.com/gonvenience/term@v1.0.0.

IsGardenContainer gets init process with pid 1, which only works on Unix-like system, but not on windows. There is no process with pid 1 on windows, which will cause nil-empty panic.

There should exist a non-nil check of the got process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants