Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: term.GetTerminalWidth failed on windows #819

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: term.GetTerminalWidth failed on windows #819

merged 1 commit into from
Feb 27, 2024

Conversation

healthjyk
Copy link
Contributor

@healthjyk healthjyk commented Feb 23, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix term.GetTerminalWidth failed on windows

Which issue(s) this PR fixes:

Fixes #534

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8016844701

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 76.845%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 81.86%
Totals Coverage Status
Change from base Build 7985663449: -0.06%
Covered Lines: 9070
Relevant Lines: 11803
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe self-assigned this Feb 27, 2024
@adohe adohe added area/cli kind/bug Something isn't working labels Feb 27, 2024
@adohe adohe added this to the v0.11.0 milestone Feb 27, 2024
adohe
adohe approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit ddb3c40 into KusionStack:main Feb 27, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@healthjyk healthjyk deleted the fix-term-getterminalwidth branch March 6, 2024 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe approved these changes

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

Assignees

@adohe adohe

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Bug: Preview detail failed on Windows
4 participants
@healthjyk @coveralls @adohe @liu-hm19