Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta flags and options for common logic and data #1005

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add meta flags and options for common logic and data

Which issue(s) this PR fixes:

Fixes #788

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Apr 6, 2024
@coveralls
Copy link

coveralls commented Apr 6, 2024

Pull Request Test Coverage Report for Build 8585777817

Details

  • 4 of 75 (5.33%) changed or added relevant lines in 7 files are covered.
  • 92 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.0%) to 56.976%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/project/paths.go 1 7 14.29%
pkg/cmd/cmd.go 0 8 0.0%
pkg/cmd/generate/generate.go 0 16 0.0%
pkg/cmd/meta/meta.go 0 41 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/profiling.go 4 0.0%
pkg/cmd/generate/generate.go 20 11.02%
pkg/cmd/cmd.go 67 0.0%
Totals Coverage Status
Change from base Build 8579085553: -1.0%
Covered Lines: 7053
Relevant Lines: 12379

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit f1c65cc into KusionStack:main Apr 7, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: unify the flags and options with the same meaning in different command line
4 participants