Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Resource.Type and Resource.Extensions in K8s Runtime #101

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Jul 18, 2022

  1. return Resource.Type and Resource.Extensions in K8s Runtime
  2. fix filesystem_state createTime bug

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/states/local
pkg/engine/runtime

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y
  1. return Resource.Type and Resource.Extensions in K8s Runtime
  2. fix filesystem_state createTime bug

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@SparkYuan SparkYuan requested review from a team, adohe, elliotxx and howieyuen July 18, 2022 15:34
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 73.205% when pulling 699bc28 on SparkYuan:fix_k8s_runtime into c28949c on KusionStack:main.

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 9a29a7e into KusionStack:main Jul 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
@SparkYuan SparkYuan deleted the fix_k8s_runtime branch June 26, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants