Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust generate cmd behavior according to latest discussion #1034

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 14, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

update generate cmd behavior according to latest discussion

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Apr 14, 2024
@adohe adohe added this to the v0.11.1 milestone Apr 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8679211406

Details

  • 4 of 54 (7.41%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 57.007%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/generate/generator/generator.go 0 5 0.0%
pkg/cmd/generate/generate.go 2 47 4.26%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/generate/generate.go 3 15.33%
Totals Coverage Status
Change from base Build 8656237463: 0.05%
Covered Lines: 7070
Relevant Lines: 12402

💛 - Coveralls

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe merged commit 41181fb into KusionStack:main Apr 14, 2024
6 checks passed
@adohe adohe deleted the update_generate_cmd branch April 14, 2024 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants