Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate cmd use terminal ui framework #1035

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 14, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

generate cmd use the terminal ui framework

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Apr 14, 2024
@adohe adohe added this to the v0.11.1 milestone Apr 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8680384642

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 55.472%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 2 0.0%
pkg/cmd/generate/generate.go 0 12 0.0%
Totals Coverage Status
Change from base Build 8679807002: 0.07%
Covered Lines: 6828
Relevant Lines: 12309

💛 - Coveralls

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe merged commit 5b5c3b6 into KusionStack:main Apr 16, 2024
8 checks passed
@adohe adohe deleted the use_new_ui branch April 16, 2024 02:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants