Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update delete cmd to follow the common cmd pattern #1041

Merged
merged 1 commit into from
Apr 16, 2024
Merged

refactor: update delete cmd to follow the common cmd pattern #1041

merged 1 commit into from
Apr 16, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 15, 2024

What type of PR is this?

What this PR does / why we need it:

update delete cmd to follow the common delete pattern

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Apr 15, 2024
@adohe adohe added this to the v0.11.1 milestone Apr 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8686561614

Details

  • 161 of 231 (69.7%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 54.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 1 0.0%
pkg/cmd/destroy/destroy.go 161 230 70.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 9 67.36%
Totals Coverage Status
Change from base Build 8679807002: -0.4%
Covered Lines: 6724
Relevant Lines: 12228
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 5b05fbe into KusionStack:main Apr 16, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@adohe adohe deleted the refact_delete_cmd branch April 16, 2024 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees

@healthjyk healthjyk

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adohe @coveralls @liu-hm19 @healthjyk