Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unexpected output in format byte slice #1052

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: unexpected output in format byte slice #1052

merged 1 commit into from
Apr 18, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix unexpected spec output format in byte slice.

image

@healthjyk healthjyk added the kind/bug Something isn't working label Apr 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8737523325

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.533%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/generate/generate.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8737499463: 0.0%
Covered Lines: 6720
Relevant Lines: 12101
💛 - Coveralls

adohe
adohe approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit 691640b into KusionStack:main Apr 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe approved these changes

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @adohe