Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the version info in the index oci url to differentiate index… #1056

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: add the version info in the index oci url to differentiate index… #1056

merged 1 commit into from
Apr 19, 2024

Conversation

SparkYuan
Copy link
Member

… versions

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@SparkYuan SparkYuan requested a review from liu-hm19 April 19, 2024 08:36
liu-hm19
liu-hm19 previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Apr 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8750887813

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 54.185%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/client/push.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.61%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/api/destroy.go 7 82.35%
Totals Coverage Status
Change from base Build 8750524203: -0.05%
Covered Lines: 8383
Relevant Lines: 15471
💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) April 19, 2024 08:47
liu-hm19
liu-hm19 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit d2ace0a into KusionStack:main Apr 19, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @liu-hm19