Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support k8s crd in kusion apply and kusion destroy #106

Merged
merged 1 commit into from
Aug 2, 2022
Merged

feat: support k8s crd in kusion apply and kusion destroy #106

merged 1 commit into from
Aug 2, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jul 25, 2022 •
edited

fix issue: #66

Support k8s CRD in kusion apply and kusion destroy:

Precondition:

  • CRD files are in YAML or JSON format, stored in crd directory under project path

Operations:

  • Read all CRD files (readCRDs()) and append to compiled result (appendCRDs())

@howieyuen howieyuen requested review from a team July 25, 2022 12:57
@coveralls
Copy link

coveralls commented Jul 25, 2022 •
edited

Coverage Status

Coverage increased (+0.06%) to 74.609% when pulling 487a951 on howieyuen:support-k8s-crd into 3299afd on KusionStack:main.

@howieyuen howieyuen added the kind/feature Categorizes issue or PR as related to a new feature label Jul 26, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 26, 2022
@howieyuen howieyuen added the cli label Jul 26, 2022
elliotxx
elliotxx reviewed Jul 26, 2022
View reviewed changes
pkg/compile/compile.go Outdated Show resolved Hide resolved
elliotxx
elliotxx reviewed Jul 26, 2022
View reviewed changes
pkg/compile/compile.go Outdated Show resolved Hide resolved
pkg/compile/compile.go Outdated Show resolved Hide resolved
@howieyuen howieyuen linked an issue Jul 27, 2022 that may be closed by this pull request
Native Support CRD in KCL and Kusion #66
Closed
@howieyuen howieyuen enabled auto-merge (squash) July 28, 2022 09:30
@howieyuen howieyuen self-assigned this Jul 28, 2022
elliotxx
elliotxx approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markliby
markliby approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 40a3090 into KusionStack:main Aug 2, 2022
@howieyuen howieyuen deleted the support-k8s-crd branch August 2, 2022 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby markliby approved these changes

Assignees

@howieyuen howieyuen

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Native Support CRD in KCL and Kusion
4 participants
@howieyuen @coveralls @elliotxx @markliby