Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update implementation of terminal ui for kusion #1061

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the implementation of Terminal UI for Kusion CLI.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Apr 22, 2024
@liu-hm19 liu-hm19 added this to the v0.11.1 milestone Apr 22, 2024
@liu-hm19 liu-hm19 self-assigned this Apr 22, 2024
@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8810682255

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 92 (50.0%) changed or added relevant lines in 9 files are covered.
  • 42 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 54.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 4 0.0%
pkg/cmd/apply/apply.go 14 19 73.68%
pkg/cmd/preview/preview.go 3 8 37.5%
pkg/engine/operation/models/change.go 0 8 0.0%
pkg/cmd/destroy/destroy.go 17 27 62.96%
pkg/cmd/generate/generate.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/generate/generate.go 1 0.0%
pkg/engine/operation/models/change.go 1 52.91%
pkg/cmd/destroy/destroy.go 1 65.85%
pkg/cmd/apply/apply.go 12 47.96%
pkg/engine/operation/port_forward.go 27 30.0%
Totals Coverage Status
Change from base Build 8782173414: 0.01%
Covered Lines: 8812
Relevant Lines: 16053

💛 - Coveralls

pkg/util/pretty/ui.go Outdated Show resolved Hide resolved
@healthjyk healthjyk merged commit c86575a into KusionStack:main Apr 24, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants