Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update kusion project and stack create #1065

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the implementation of kusion project create and kusion stack create, adding a hint when project and stack successfully created.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Apr 24, 2024
@liu-hm19 liu-hm19 added this to the v0.11.1 milestone Apr 24, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan April 24, 2024 03:31
@liu-hm19 liu-hm19 self-assigned this Apr 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8810606986

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 54.953%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/stack/create/options.go 3 5 60.0%
Totals Coverage Status
Change from base Build 8800608904: 0.1%
Covered Lines: 8815
Relevant Lines: 16041

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit cfd6212 into KusionStack:main Apr 24, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants