Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init target project name #1068

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug of kusion init target project name.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Apr 25, 2024
@liu-hm19 liu-hm19 added this to the v0.11.1 milestone Apr 25, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan April 25, 2024 03:19
@liu-hm19 liu-hm19 self-assigned this Apr 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8826512822

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 54.923%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/init/options.go 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/apply.go 7 47.96%
Totals Coverage Status
Change from base Build 8814156476: 0.02%
Covered Lines: 8825
Relevant Lines: 16068

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) April 25, 2024 03:33
@SparkYuan SparkYuan modified the milestones: v0.11.1, v0.12.0 May 6, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6c426ce into KusionStack:main Jun 6, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants