Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: add configs in the workspace mod definition (#1066)" #1069

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

SparkYuan
Copy link
Member

This reverts commit ba43927. We'll move this commit to the next version

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from liu-hm19 April 25, 2024 03:29
…nStack#1066)"

This reverts commit ba43927.
We'll move this commit to the next version
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8826601851

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 54.969%

Totals Coverage Status
Change from base Build 8826589864: 0.004%
Covered Lines: 8828
Relevant Lines: 16060

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit a3a2ac9 into KusionStack:main Apr 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants