Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: save unchanged but lived resource #107

Merged
merged 1 commit into from
Aug 2, 2022
Merged

bugfix: save unchanged but lived resource #107

merged 1 commit into from
Aug 2, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jul 26, 2022 •
edited

fix: #102

Resource is living in Runtime, but not applied by kusion, next time user use kusion to apply the same Resource but no changes, kusion should save it in State

@howieyuen howieyuen requested a review from a team July 26, 2022 08:00
@howieyuen howieyuen force-pushed the save-unchanged-but-lived-resource branch from 3bbb370 to 049d08d Compare July 26, 2022 08:02
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 74.66% when pulling 049d08d on howieyuen:save-unchanged-but-lived-resource into 3299afd on KusionStack:main.

@howieyuen howieyuen changed the title Save unchanged but lived resource bugfix: Save unchanged but lived resource Jul 26, 2022
@howieyuen howieyuen changed the title bugfix: Save unchanged but lived resource bugfix: save unchanged but lived resource Jul 26, 2022
@howieyuen howieyuen added kind/bug Something isn't working engine labels Jul 27, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 27, 2022
@howieyuen howieyuen enabled auto-merge (squash) July 28, 2022 09:30
@howieyuen howieyuen self-assigned this Jul 28, 2022
elliotxx
elliotxx approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markliby
markliby approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 2109bf4 into KusionStack:main Aug 2, 2022
@howieyuen howieyuen deleted the save-unchanged-but-lived-resource branch August 2, 2022 08:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby markliby approved these changes

Assignees

@howieyuen howieyuen

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Missing resources in the kusion_state.json file when applying resources already in the k8s cluster
4 participants
@howieyuen @coveralls @elliotxx @markliby