Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace update defaults to use current workspace #1075

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes the bug of kusion workspace update not supporting current workspace if not specified.

Which issue(s) this PR fixes:

Fixes #1073

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Apr 26, 2024
@liu-hm19 liu-hm19 added this to the v0.11.1 milestone Apr 26, 2024
@liu-hm19 liu-hm19 self-assigned this Apr 26, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8844220203

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 54.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/workspace/update/options.go 1 4 25.0%
Totals Coverage Status
Change from base Build 8827966150: 0.1%
Covered Lines: 8829
Relevant Lines: 16065

💛 - Coveralls

@SparkYuan SparkYuan merged commit b999f67 into KusionStack:main Apr 26, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: can't find workspace name when updating current workspace
3 participants