New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the bug of workspace update without name #1078

Merged

adohe merged 1 commit into KusionStack:main from healthjyk:fix-ws-update

Apr 29, 2024

Contributor

healthjyk commented Apr 28, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:


          fix: the bug of workspace update without name

071d3ba

coveralls commented Apr 28, 2024

Pull Request Test Coverage Report for Build 8864855425

Details

1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 54.906%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cmd/workspace/update/options.go	1	5	20.0%

Totals
Change from base Build 8846462614:	0.05%
Covered Lines:	8830
Relevant Lines:	16082

💛 - Coveralls

adohe approved these changes

View reviewed changes

Contributor

adohe left a comment

/lgtm

adohe merged commit 92243b5 into KusionStack:main

6 checks passed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.