Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse module name and version from the kcl.mod in mod push #1080

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from adohe April 28, 2024 11:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8867321911

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 54.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/mod/mod_push.go 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/mod/mod_push.go 1 0.0%
pkg/cmd/destroy/destroy.go 7 63.16%
Totals Coverage Status
Change from base Build 8866434542: -0.08%
Covered Lines: 8819
Relevant Lines: 16091

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) April 28, 2024 11:51
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SparkYuan SparkYuan merged commit 2d9c0c9 into KusionStack:main Apr 29, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants