Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context in the workspace #1113

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9056850674

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/plugin.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/app_configurations_generator.go 1 64.63%
pkg/workspace/validation.go 1 82.48%
pkg/engine/operation/parser/parser.go 3 75.61%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 9042078096: -0.2%
Covered Lines: 8804
Relevant Lines: 16057

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) May 13, 2024 03:58
Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 2bc1c28 into KusionStack:main May 13, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants