Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add context in the module grpc #1118

Merged
merged 1 commit into from
May 13, 2024
Merged

feat: add context in the module grpc #1118

merged 1 commit into from
May 13, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9060983496

Details

  • 18 of 32 (56.25%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 54.876%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/app_configurations_generator.go 18 23 78.26%
pkg/modules/proto/module.pb.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/app_configurations_generator.go 1 64.45%
Totals Coverage Status
Change from base Build 9058269108: 0.003%
Covered Lines: 8818
Relevant Lines: 16069
💛 - Coveralls

Liuxingyu1111111
Liuxingyu1111111 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit be37829 into KusionStack:main May 13, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Liuxingyu1111111 Liuxingyu1111111 Liuxingyu1111111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @Liuxingyu1111111