Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json patch in the module generate method #1127

Merged
merged 1 commit into from
May 20, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

support json patch in the module generate method

Which issue(s) this PR fixes:

Fixes #1097

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9156055649

Details

  • 33 of 48 (68.75%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 54.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/proto/module.pb.go 0 2 0.0%
pkg/modules/generators/app_configurations_generator.go 33 46 71.74%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/app_configurations_generator.go 1 66.28%
pkg/cmd/destroy/destroy.go 7 63.16%
Totals Coverage Status
Change from base Build 9111712148: 0.02%
Covered Lines: 8827
Relevant Lines: 16112

💛 - Coveralls

Copy link
Contributor

@Liuxingyu1111111 Liuxingyu1111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 7feee90 into KusionStack:main May 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: module patcher supports patch other resources with json patch
3 participants