Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore built-in workloads during generating the Spec #1128

Merged
merged 1 commit into from
May 21, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from liu-hm19 May 21, 2024 09:03
@SparkYuan SparkYuan enabled auto-merge (squash) May 21, 2024 09:03
@SparkYuan SparkYuan disabled auto-merge May 21, 2024 09:03
@SparkYuan SparkYuan enabled auto-merge (squash) May 21, 2024 09:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9171932831

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 54.957%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/api/generate/generator/generator.go 0 3 0.0%
Totals Coverage Status
Change from base Build 9170377279: 0.03%
Covered Lines: 8891
Relevant Lines: 16178

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 46465fc into KusionStack:main May 21, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants