Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use release to update state usage in preview/apply/destroy #1130

Merged
merged 1 commit into from
May 22, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk healthjyk force-pushed the usage-release branch 3 times, most recently from 82ffc79 to 71a6b69 Compare May 22, 2024 04:01
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9186991581

Details

  • 256 of 598 (42.81%) changed or added relevant lines in 19 files are covered.
  • 75 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.6%) to 54.306%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/meta/meta.go 0 1 0.0%
pkg/engine/api/destroy.go 19 20 95.0%
pkg/engine/operation/graph/resource_node.go 1 2 50.0%
pkg/engine/api/apply.go 14 16 87.5%
pkg/engine/operation/parser/spec_parser.go 2 4 50.0%
pkg/engine/operation/preview.go 18 20 90.0%
pkg/cmd/preview/preview.go 17 21 80.95%
pkg/engine/operation/port_forward.go 10 15 66.67%
pkg/engine/operation/watch.go 6 12 50.0%
pkg/engine/operation/destory.go 31 39 79.49%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/spec_parser.go 1 65.85%
pkg/engine/operation/destory.go 2 84.21%
pkg/engine/operation/apply.go 2 74.62%
pkg/server/manager/stack/stack_manager.go 9 19.48%
pkg/cmd/apply/apply.go 10 48.08%
pkg/engine/api/apply.go 19 63.16%
pkg/cmd/destroy/destroy.go 32 52.38%
Totals Coverage Status
Change from base Build 9185075204: -0.6%
Covered Lines: 8917
Relevant Lines: 16420

💛 - Coveralls

@healthjyk
Copy link
Contributor Author

All tested!
a> kusion preview
image
b> kusion apply
image
c> kusion destroy
image

@healthjyk healthjyk requested a review from SparkYuan May 22, 2024 07:20
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 7765bc1 into KusionStack:main May 22, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants