Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customize namespace issue to get correct k8s namespace name #1132

Merged
merged 1 commit into from
May 23, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented May 22, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

#1117

Which issue(s) this PR fixes:

Fixes #1117

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/bug Something isn't working label May 22, 2024
@adohe adohe added this to the v0.12.0 milestone May 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9201468392

Details

  • 26 of 34 (76.47%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 54.373%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/app_configurations_generator.go 25 33 75.76%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
pkg/modules/generators/app_configurations_generator.go 1 69.48%
Totals Coverage Status
Change from base Build 9189250126: 0.02%
Covered Lines: 8915
Relevant Lines: 16396

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 57dcede into KusionStack:main May 23, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: customized namespace extension in project.yaml and stack.yaml
3 participants